fix: benchmark suite reliability improvements - #156
Merged
Merged
Conversation
- bench-memory.sh: anchor grep to ^used_memory: so it doesn't match used_memory_human: (was causing 0 bytes/key for all types) - bench-proto.sh: pass --protobuf flag to ember-server (runtime flag required in addition to compile-time feature) - setup-vm.sh: disable redis systemd service after install (was squatting on port 6379 and interfering with benchmarks), install gcc-12/protoc/python3-venv/unzip, build with all features
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
- bench-memory.sh: anchor grep to ^used_memory: so it doesn't match used_memory_human: (was causing 0 bytes/key for all types) - bench-proto.sh: pass --protobuf flag to ember-server (runtime flag required in addition to compile-time feature) - setup-vm.sh: disable redis systemd service after install (was squatting on port 6379 and interfering with benchmarks), install gcc-12/protoc/python3-venv/unzip, build with all features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
three fixes that caused benchmark failures on the last GCP run:
^used_memory:— the unanchored pattern was matching bothused_memory:andused_memory_human:, producing multi-line output that broke the arithmetic (all types reported 0 bytes/key)--protobufruntime flag to ember-server — the feature flag enables compilation, but the server also requires--protobufat startup to initialize the schema registrywhat was tested
INFO memoryreturns singleused_memory:line with anchored grep--protobufflag initializes schema registry (PROTO.REGISTER succeeds)